check container_name is not in use by another service we will create #11713
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
a team,
glours,
milas and
jhrotko
and removed request for
a team
|
Ho can we add a test to be sure we won't have regression in future as this check is managed here now and not in |
|
@glours I have a test case ready but need to wait for compose-spec/compose-go#619 to be merged otherwise test will fail as compose-go will prevent loading compose.yaml file with same container_name used by services |
ndeloof
force-pushed
the
container_name
branch
2 times, most recently
from
182b2ca
to
0b41c75
Compare
milas
reviewed
Apr 16, 2024
pkg/compose/create.go
Outdated
| func (s *composeService) create(ctx context.Context, project *types.Project, options api.CreateOptions) error { | ||
| if len(options.Services) == 0 { | ||
| options.Services = project.ServiceNames() | ||
| } | ||
|
|
||
| err := checkContainerNameUnicity(project) |
There was a problem hiding this comment.
I think we should also call this on compose config
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
check container_name is not in use by another service we will create
Related issue
see compose-spec/compose-go#619
(not mandatory) A picture of a cute animal, if possible in relation to what you did
