Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env: fix a bunch of escaping/parsing edge cases #308

Merged
merged 6 commits into from Sep 26, 2022
Merged

env: fix a bunch of escaping/parsing edge cases #308

merged 6 commits into from Sep 26, 2022

Commits on Sep 23, 2022

  1. env: fix a bunch of escaping/parsing edge cases 

    * Handle standard escape sequences based on XSI/XBD
  https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html
* Fix parsing with escaped quotes at end of quoted
  value
* Handle key whose name starts with `export` (require
  whitespace between `export` keyword when stripping)
* Fix parsing of unquoted values with embedded `#`
  (require a space before starting an inline comment)
* Use correct parser methods throughout all test cases
* Eliminate a lot of unused code that was not working
  right

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Sep 23, 2022
    Copy the full SHA
    e3531d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Merge remote-tracking branch 'upstream/master' into env-parser-escapes

    @milas
    milas committed Sep 26, 2022
    Copy the full SHA
    03bca44 View commit details
    Browse the repository at this point in the history

  2. ci: run go mod tidy for 1.18 

    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Sep 26, 2022
    Copy the full SHA
    ce012ee View commit details
    Browse the repository at this point in the history

  3. remove conditional build for 1.17 compat 

    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Sep 26, 2022
    Copy the full SHA
    5b35f69 View commit details
    Browse the repository at this point in the history

  4. restore deleted functions as deprecated 

    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Sep 26, 2022
    Copy the full SHA
    7d9b4f6 View commit details
    Browse the repository at this point in the history

  5. test: more escape cases 

    Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Sep 26, 2022
    Copy the full SHA
    300f36b View commit details
    Browse the repository at this point in the history