env: fix a bunch of escaping/parsing edge cases #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
force-pushed
the
env-parser-escapes
branch
from
e25772b
to
f297e4c
Compare
milas
commented
Sep 23, 2022
Comment on lines
+420
to
+422
| parseAndCompare(t, `FOO="bar\n\ b\az"`, "FOO", "bar\n\\ b\az") | ||
| parseAndCompare(t, `FOO="bar\\\n\ b\az"`, "FOO", "bar\\\n\\ b\az") | ||
| parseAndCompare(t, `FOO="bar\\r\ b\az"`, "FOO", "bar\\r\\ b\az") |
There was a problem hiding this comment.
N.B. It was buggy here before! It was stripping \ characters on "unknown" escape sequences, which is...not desirable 🙈
* Handle standard escape sequences based on XSI/XBD https://pubs.opengroup.org/onlinepubs/9699919799/utilities/echo.html * Fix parsing with escaped quotes at end of quoted value * Handle key whose name starts with `export` (require whitespace between `export` keyword when stripping) * Fix parsing of unquoted values with embedded `#` (require a space before starting an inline comment) * Use correct parser methods throughout all test cases * Eliminate a lot of unused code that was not working right Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
env-parser-escapes
branch
from
f297e4c
to
e3531d4
Compare
glours
requested changes
Sep 26, 2022
glours
reviewed
Sep 26, 2022
| @@ -1,6 +1,6 @@ | |||
| module github.com/compose-spec/compose-go | |||
|
|
|||
| go 1.17 | |||
| go 1.18 | |||
There was a problem hiding this comment.
🫣 Ho I didn't check we were still using 1.17 here 😬
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
env-parser-escapes
branch
from
f3671f6
to
300f36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\for non-escape sequences (e.g.\jshould still be\j, notj)export(require whitespace betweenexportkeyword when stripping)#(require a space before starting an inline comment)