Fix 500

[jacadzaca]

fix #500

[coveralls]

Pull Request Test Coverage Report for Build 3707937262

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 93.333%

---

Totals
Change from base Build 3612230234:	0.01%
Covered Lines:	1162
Relevant Lines:	1245

---

💛 - Coveralls

[jacadzaca]

@mauritsvanrees plone tests failed

[mauritsvanrees]

@mauritsvanrees plone tests failed

@jacadzaca This is a problem with tox, where 4.0.0 was recently released. On tox 3 the job works fine, but on 4 we need a small change:

-    pip install -e "git+https://github.com/plone/plone.app.event.git#egg=plone.app.event"
+    pip install -e "git+https://github.com/plone/plone.app.event.git\#egg=plone.app.event"

I have added a commit to your branch.

[tisdall]

Thanks for fixing this!

[tisdall]

I think the fix covers all the property types... vInt, vTime, etc

[jacadzaca]

You're probably right, but I don't put things in the changelog if there isn't a corresponding test for the entry.

[niccokunzmann]

If you put it in the changelog, it creates an expectation and then people come back if this is not the case. But since it is in the documentation, the expectation is there either way.

[tisdall]

Should there be tests for some of the other types or is that excessive? Basically everything with an .to_ical() method works and I'm assuming there's test already for those methods.

[jacadzaca]

There are tests for proper encoding for other v types, but I don't think there are any for checking if they can be used as a param. If you've got the time to file a PR with a parametrization of this test for other v types I'll gladly accept it :) if you don't, I will try to update the test sometime next week :)

[niccokunzmann]

The None return is interesting. When does it hit?

[niccokunzmann]

I see the tests running and from the conversation there arises no problem. I merge. The library is better than before.