New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 500 #501
Fix 500 #501
Changes from all commits
0e0fdc5
b47aba5
230c466
d8b5e34
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -102,7 +102,10 @@ def param_value(value): | |
""" | ||
if isinstance(value, SEQUENCE_TYPES): | ||
return q_join(value) | ||
return dquote(value) | ||
elif isinstance(value, str): | ||
return dquote(value) | ||
else: | ||
return dquote(value.to_ical().decode(DEFAULT_ENCODING)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The None return is interesting. When does it hit? |
||
|
||
|
||
# Could be improved | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
BEGIN:VEVENT | ||
ATTENDEE;RSVP=TRUE:mailto:someone@example.com | ||
END:VEVENT |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from icalendar import Event, vBoolean, vCalAddress | ||
|
||
def test_vBoolean_can_be_used_as_parameter_issue_500(events): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should there be tests for some of the other types or is that excessive? Basically everything with an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are tests for proper encoding for other v types, but I don't think there are any for checking if they can be used as a param. If you've got the time to file a PR with a parametrization of this test for other v types I'll gladly accept it :) if you don't, I will try to update the test sometime next week :) |
||
'''https://github.com/collective/icalendar/issues/500''' | ||
attendee = vCalAddress(f'mailto:someone@example.com') | ||
attendee.params['rsvp'] = vBoolean(True) | ||
event = Event() | ||
event.add('attendee', attendee) | ||
assert event.to_ical() == events.event_with_rsvp.raw_ics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the fix covers all the property types...
vInt
,vTime
, etcThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably right, but I don't put things in the changelog if there isn't a corresponding test for the entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you put it in the changelog, it creates an expectation and then people come back if this is not the case. But since it is in the documentation, the expectation is there either way.