Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parser.py #502

Merged
merged 1 commit into from Apr 13, 2023
Merged

Update parser.py #502

merged 1 commit into from Apr 13, 2023

Conversation

N0ury
Copy link
Contributor

@N0ury N0ury commented Dec 16, 2022

issue #348

@coveralls
Copy link

coveralls commented Dec 16, 2022 •
edited

Pull Request Test Coverage Report for Build 3713390001

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.333%
Totals Coverage Status
Change from base Build 3612230234: 0.01%
Covered Lines: 1162
Relevant Lines: 1245
💛 - Coveralls

@jacadzaca jacadzaca linked an issue Dec 16, 2022 that may be closed by this pull request
Exception when there's no ':' when parsing value #348
Closed
@jacadzaca jacadzaca self-requested a review December 16, 2022 15:37
@jacadzaca
Copy link
Collaborator

thanks for contributing :) we'll merge when #500 gets merged, so the tests are green.

@jacadzaca
Copy link
Collaborator

jacadzaca commented Dec 16, 2022 •
edited

@N0ury could you please add yourself to the credits and add a changelog entry as per CONTRIBUTING? I'd also much appreciate if you amended the commit message to something more descriptive, e.g: "fix parsing of parameters with missing : #348". Thanks for the contribution once again :)

@niccokunzmann
Copy link
Member

#501 has been merged. If the master branch is merged into this one, the tests should be green again.

@niccokunzmann
Copy link
Member

I wonder if this fixes the tests from #436.

This was referenced Dec 28, 2022
Closed
Open
@niccokunzmann niccokunzmann mentioned this pull request Apr 12, 2023
Merged
@niccokunzmann niccokunzmann merged commit cd76193 into collective:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacadzaca jacadzaca jacadzaca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when there's no ':' when parsing value
4 participants
@N0ury @coveralls @jacadzaca @niccokunzmann