Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out distribute_and_unnest_attrs #243

Merged
merged 4 commits into from
Mar 21, 2022

Commits on Mar 17, 2022

  1. Break out distribute_and_unnest_attrs

    Replaces two copies of the same code, in Field::unnest_attrs and
    Options::unnest_attrs.
    
    Also, replaces the double specification of the output attributes list
    variables in each of these functions (once when calculating unnest,
    and once when copying the fields to every output).
    
    Discussion was here, et seq:
      colin-kiegel#241 (comment)
    ijackson committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1db242c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Adjust comment

    Co-authored-by: Ted Driggs <ted.driggs@outlook.com>
    ijackson and TedDriggs committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    91909e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a59778 View commit details
    Browse the repository at this point in the history
  3. Clarify variable names

    ijackson committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    36d5442 View commit details
    Browse the repository at this point in the history