Break out distribute_and_unnest_attrs #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces two copies of the same code, in Field::unnest_attrs and Options::unnest_attrs. Also, replaces the double specification of the output attributes list variables in each of these functions (once when calculating unnest, and once when copying the fields to every output). Discussion was here, et seq: colin-kiegel#241 (comment)
TedDriggs
reviewed
Mar 17, 2022
Co-authored-by: Ted Driggs <ted.driggs@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC, as discussed in #241 (comment) . It seemed better to demonstrate it rather than talk in the abstract.
I think it has come out quite nicely. In particular, removing the duplicated specification of the output field variables now means it's not possible to accidentally get the unnesting and copying information out of step.
But if you prefer the code the way it is, please do feel free to say so and just close this MR.