[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates #18530

mdlinville · 2024-05-09T18:08:56Z

[DOC-10090] v24.1.0 deprecations and backward-incompatible changes
[DOC-10093] v24.1.0 licensing updates

Also fix a display bug in v23.1.0 release notes

Relates to [DOC-10061]

Preview: releases/v24.1.md

github-actions · 2024-05-09T18:09:26Z

Files changed:

src/current/_includes/releases/v23.1/v23.1.0.md:
- releases/v23.1.md
src/current/_includes/releases/v24.1/v24.1.0-alpha.1.md:
- releases/v24.1.md
src/current/_includes/releases/v24.1/v24.1.0.md:
- releases/v24.1.md
src/current/v24.1/licensing-faqs.md

netlify · 2024-05-09T18:09:36Z

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	`7615fd9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6647d70504e6e400088ee0cc

netlify · 2024-05-09T18:09:40Z

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	`7615fd9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6647d705daa0020008db8a16

netlify · 2024-05-09T18:14:37Z

✅ Netlify Preview

Name	Link
🔨 Latest commit	`7615fd9`
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/6647d705864e1a00080766f2
😎 Deploy Preview	https://deploy-preview-18530--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

taroface · 2024-05-09T20:33:10Z

Here's my suggested addition:

The `sql.txn.read_committed_isolation.enabled` [cluster setting]({% link {{ page.version.version }}/cluster-setting.md %}) is now `true` by default. [`READ COMMITTED`]({% link {{ page.version.version }}/read-committed.md %}) transactions are no longer automatically upgraded to [`SERIALIZABLE`]({% link {{ page.version.version }}/demo-serializable.md %}), and will run as `READ COMMITTED`. As a result, upgrading CockroachDB may affect your application behavior. To see whether any transactions are being upgraded from weaker isolation levels to `SERIALIZABLE` on v23.2, check the [**Upgrades of SQL Transaction Isolation Level**]({% link {{ page.version.version }}/ui-sql-dashboard.md %}#upgrades-of-sql-transaction-isolation-level) graph in the DB Console. You may need to adjust those transactions before upgrading to v24.1.

If this needs to be associated with a PR, I think this should be the one: cockroachdb/cockroach#118479

See: cockroachdb/cockroach#118497 and this comment for context

mdlinville · 2024-05-09T23:37:46Z

Here's my suggested addition:

The `sql.txn.read_committed_isolation.enabled` [cluster setting]({% link {{ page.version.version }}/cluster-setting.md %}) is now `true` by default. [`READ COMMITTED`]({% link {{ page.version.version }}/read-committed.md %}) transactions are no longer automatically upgraded to [`SERIALIZABLE`]({% link {{ page.version.version }}/demo-serializable.md %}), and will run as `READ COMMITTED`. As a result, upgrading CockroachDB may affect your application behavior. To see whether any transactions are being upgraded from weaker isolation levels to `SERIALIZABLE` on v23.2, check the [**Upgrades of SQL Transaction Isolation Level**]({% link {{ page.version.version }}/ui-sql-dashboard.md %}#upgrades-of-sql-transaction-isolation-level) graph in the DB Console. You may need to adjust those transactions before upgrading to v24.1.

If this needs to be associated with a PR, I think this should be the one: cockroachdb/cockroach#118479

See: cockroachdb/cockroach#118497 and this comment for context

Thanks, PTAL, I took your wording and gave it a few nitpicky tweaks.

src/current/_includes/releases/v24.1/v24.1.0.md

taroface

The READ COMMITTED item LGTM!

rafiss · 2024-05-13T19:56:57Z

src/current/_includes/releases/v24.1/v24.1.0.md

@@ -241,7 +241,8 @@ In CockroachDB Self-Hosted, all available features are free to use unless their

 Before [upgrading to CockroachDB v24.1]({% link v24.1/upgrade-cockroach-version.md %}), be sure to review the following backward-incompatible changes, as well as [key cluster setting changes](#v24-1-0-cluster-settings), and adjust your deployment as necessary.

- TBD
+- [`AS OF SYSTEM TIME`]({% link v23.2/as-of-system-time.md %}) queries can no longer use a timestamp followed by a question mark to signify a future-time value. This was an undocumented syntax. [#116830](https://github.com/cockroachdb/cockroach/pull/116830)
+- The `sql.txn.read_committed_isolation.enabled` [cluster setting]({% link v24.1/cluster-settings.md %}) is now `true` by default. As a result, [`READ COMMITTED`]({% link v24.1/read-committed.md %}) transactions are **not** automatically upgraded to [`SERIALIZABLE`]({% link v24.1/demo-serializable.md %}), and will run as `READ COMMITTED` by default. On v23.2, refer to the [**Upgrades of SQL Transaction Isolation Level**]({% link v24.1/ui-sql-dashboard.md %}#upgrades-of-sql-transaction-isolation-level) graph in the DB Console to check whether any transaction is being upgraded from a weaker isolation level to `SERIALIZABLE`, and could therefore run differently on v24.1. [#118479](https://github.com/cockroachdb/cockroach/pull/118479)


All of the info looks correct to me. Just one more higher level question -- should this also mention that READ COMMITTED is enterprise only?

I.e., if you don't have an enterprise license, then even if the setting is on, the auto-upgrade to SERIALIZABLE will still happen. (Maybe this is something better left for the detailed docs, and I also don't want to derail this PR too much. I'm fine with whatever you decide, just mentioning it in case.)

OK that's an important point -- I think this needs to be a separate backward-incompatible note, placed above this one about the txn upgrades.

cc @mdlinville (this just keeps the wording of the release note):

- The `READ COMMITTED` isolation level now requires the cluster to have a valid enterprise license. [#120154](https://github.com/cockroachdb/cockroach/pull/120154)

Done. PTAL because I added a little more detail to the end of your draft, and also added it to a new Enterprise Features section directly above the Backward-Incompatible Changes section.

rafiss

lgtm!

taroface

1 correction and 1 clarification - let me know if it makes sense.

src/current/_includes/releases/v24.1/v24.1.0.md

taroface

LGTM, one formatting nit

src/current/_includes/releases/v24.1/v24.1.0.md

…anges, license changes - Also fix a display bug in v23.1.0 release notes - Also update license conversion timelines for 23.2 and 24.1

This was referenced May 9, 2024

check whether READ COMMITTED txns are being upgraded #18533

Closed

Read Committed 40001 errors; lock promotion #18522

Merged

taroface self-requested a review May 10, 2024 14:31

taroface requested changes May 10, 2024

View reviewed changes

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

mdlinville requested review from taroface and rafiss May 10, 2024 22:37

mdlinville commented May 10, 2024

View reviewed changes

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

mdlinville force-pushed the DOC-10090 branch from f9191ff to 1776d6b Compare May 13, 2024 19:19

taroface approved these changes May 13, 2024

View reviewed changes

rafiss approved these changes May 13, 2024

View reviewed changes

mdlinville force-pushed the DOC-10090 branch from 877d920 to bdbc167 Compare May 13, 2024 22:50

mdlinville changed the title ~~[DOC-10090] v24.1.0 deprecations and backward-incompatible changes~~ [DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates May 13, 2024

mdlinville requested review from taroface and rafiss May 13, 2024 22:53

mdlinville force-pushed the DOC-10090 branch from bdbc167 to 204e01c Compare May 13, 2024 23:04

rafiss approved these changes May 14, 2024

View reviewed changes

taroface requested changes May 14, 2024

View reviewed changes

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

src/current/_includes/releases/v24.1/v24.1.0.md Show resolved Hide resolved

mdlinville requested a review from taroface May 14, 2024 22:46

exalate-issue-sync bot mentioned this pull request May 15, 2024

release note about sql.txn.upgraded_iso_level.count metric #18374

Closed

taroface approved these changes May 17, 2024

View reviewed changes

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

src/current/_includes/releases/v24.1/v24.1.0.md Outdated Show resolved Hide resolved

[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible ch…

7615fd9

…anges, license changes - Also fix a display bug in v23.1.0 release notes - Also update license conversion timelines for 23.2 and 24.1

mdlinville force-pushed the DOC-10090 branch from a93beb8 to 7615fd9 Compare May 17, 2024 22:15

mdlinville enabled auto-merge (squash) May 17, 2024 22:16

mdlinville merged commit aaaf92d into main May 17, 2024
6 of 7 checks passed

mdlinville deleted the DOC-10090 branch May 17, 2024 22:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates #18530

[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates #18530

mdlinville commented May 9, 2024 •

edited

github-actions bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

taroface commented May 9, 2024 •

edited

mdlinville commented May 9, 2024

taroface left a comment

rafiss May 13, 2024

taroface May 13, 2024 •

edited

mdlinville May 13, 2024

rafiss left a comment

taroface left a comment

taroface left a comment

[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates #18530

[DOC-10090][DOC-10093] v24.1.0 deprecations, backward-incompatible changes, licensing updates #18530

Conversation

mdlinville commented May 9, 2024 • edited

github-actions bot commented May 9, 2024 • edited

Files changed:

netlify bot commented May 9, 2024 • edited

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

netlify bot commented May 9, 2024 • edited

✅ Deploy Preview for cockroachdb-api-docs canceled.

netlify bot commented May 9, 2024 • edited

✅ Netlify Preview

taroface commented May 9, 2024 • edited

mdlinville commented May 9, 2024

taroface left a comment

Choose a reason for hiding this comment

rafiss May 13, 2024

Choose a reason for hiding this comment

taroface May 13, 2024 • edited

Choose a reason for hiding this comment

mdlinville May 13, 2024

Choose a reason for hiding this comment

rafiss left a comment

Choose a reason for hiding this comment

taroface left a comment

Choose a reason for hiding this comment

taroface left a comment

Choose a reason for hiding this comment

mdlinville commented May 9, 2024 •

edited

github-actions bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

netlify bot commented May 9, 2024 •

edited

taroface commented May 9, 2024 •

edited

taroface May 13, 2024 •

edited