Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release note about sql.txn.upgraded_iso_level.count metric #18374

Closed
michae2 opened this issue Mar 12, 2024 · 3 comments
Closed

release note about sql.txn.upgraded_iso_level.count metric #18374

michae2 opened this issue Mar 12, 2024 · 3 comments
Assignees

Comments

@michae2
Copy link

michae2 commented Mar 12, 2024

Michael Erickson (michae2) commented:

When upgrading from 23.2 to 24.1, cluster setting sql.txn.read_committed_isolation.enabled will be enabled by default, meaning transactions started with BEGIN TRANSACTION ISOLATION LEVEL READ COMMITTED will actually use read committed isolation instead of silently being promoted to serializable isolation. This could be considered a breaking change, because the behavior of the two isolation levels is different.

In order to help users prepare for the 23.2 to 24.1 upgrade, we've introduced a new metric in 23.2.3 called sql.txn.upgraded_iso_level.count which shows how many transactions are currently undergoing this silent promotion from read committed isolation to serializable isolation, and would be affected. (This metric shows up in the DB console under Metrics > SQL > Upgrades of SQL Transaction Isolation Level.)

We should add a release note for users about checking this metric before upgrading to 24.1. If the metric shows that there are transactions being promoted from RC to serializable, users will want to inspect those transactions and be aware of the change in isolation level in 24.1. If they would like to continue using the silent promotion to serializable isolation, they should SET CLUSTER SETTING sql.txn.read_committed_isolation.enabled = false;.

Jira Issue: DOC-9868

@michae2
Copy link
Author

michae2 commented Mar 12, 2024

(If it helps, this metric was added by cockroachdb/cockroach#118497.)

@exalate-issue-sync exalate-issue-sync bot assigned mdlinville and unassigned taroface Mar 13, 2024
Copy link

Shannon Bradshaw (shannonbradshaw) commented:
Assigning to Matt, because this is really more of an upgrade concern.

@exalate-issue-sync exalate-issue-sync bot assigned taroface and unassigned mdlinville Mar 14, 2024
Copy link

Ryan Kuo (taroface) commented:
This was resolved with #18522 and will also be addressed in #18530 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants