Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve linting perf via caching #5900

Merged
merged 20 commits into from Dec 22, 2022
Merged
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/source_aws.yml
Expand Up @@ -54,7 +54,7 @@ jobs:
cache: true
cache-dependency-path: plugins/source/aws/go.sum
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
uses: bbernays/golangci-lint-action@58bce521b66ed125524e24eeec9522d765a8c2a7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the fork under cloudquery/ and also use the branch name directly cloudquery/golangci-lint-action@master so if we follow up with fixes we don't have to update this sha

with:
version: v1.50.1
working-directory: plugins/source/aws
Expand Down