Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci-wait-for-all): Use Ana06/get-changed-files to compare PRs with main #3158

Merged
merged 4 commits into from
Oct 20, 2022
Merged

chore(ci-wait-for-all): Use Ana06/get-changed-files to compare PRs with main #3158

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56e7018
chore(ci-wait-for-all): Set head and base sha for PRs
erezrokah Oct 20, 2022
062305a
chore(ci-wait-for-all): Use jitterbit/get-changed-files
erezrokah Oct 20, 2022
ee2496a
Update wait_for_required_workflows.yml
erezrokah Oct 20, 2022
4f27326
Merge branch 'main' into chore/set_head_base_sha
kodiakhq[bot] Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/wait_for_required_workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v32
uses: jitterbit/get-changed-files@v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action uses the GitHub API to do the diff, which should use a three dots diff.
We've used it before and removed it since it caused us to hit rate limits.
Since we're now on enterprise account our limit increased from 1000 to 15000 request per hour so I think we can try this again until tj-actions/changed-files#702 is resolved.

Another benefit is that we can do a shallow clone which is faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so jitterbit/get-changed-files#19 (comment) works

- uses: actions/github-script@v6
env:
FILES: ${{ steps.changed-files.outputs.all_changed_files }}
FILES: ${{ steps.changed-files.outputs.all }}
with:
script: |
const files = process.env.FILES.split(' ')
Expand Down