chore(ci-wait-for-all): Use Ana06/get-changed-files to compare PRs with main
#3158
Conversation
erezrokah
force-pushed
the
chore/set_head_base_sha
branch
from
55ec13e
to
56e7018
Compare
|
Actually I think the issue is that this action uses a two dots diff instead of a three dots diff, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-comparing-branches-in-pull-requests#three-dot-and-two-dot-git-diff-comparisons |
erezrokah
force-pushed
the
chore/set_head_base_sha
branch
from
a5c7b1f
to
062305a
Compare
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v32 | ||
| uses: jitterbit/get-changed-files@v1 |
There was a problem hiding this comment.
This action uses the GitHub API to do the diff, which should use a three dots diff.
We've used it before and removed it since it caused us to hit rate limits.
Since we're now on enterprise account our limit increased from 1000 to 15000 request per hour so I think we can try this again until tj-actions/changed-files#702 is resolved.
Another benefit is that we can do a shallow clone which is faster
There was a problem hiding this comment.
OK so jitterbit/get-changed-files#19 (comment) works
erezrokah
changed the title
changed-files actionAna06/get-changed-files to compare PRs with main
|
@hermanschaaf sorry for the back and forth this is ready now |
Summary
It seems this action fails to use the correctshaof the PR if the PR branch is not up to date. This should fix itUse an action that uses the GitHub API as we need a three dots diff