LogpushJob.Filter is optional #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfaulkner
force-pushed
the
optional-filter
branch
3 times, most recently
from
d14cfc9
to
6f1778d
Compare
|
changelog detected ✅ |
|
This pull request contains a CHANGELOG.md file which should only be modified by maintainers. If you are looking to include a CHANGELOG entry, you should use the process documented at https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md instead. In order for this pull request to be merged, you need remove the modifications to CHANGELOG.md. |
sbfaulkner
force-pushed
the
optional-filter
branch
from
6f1778d
to
5fd30ef
Compare
|
rebased to not include changes from our fork |
sbfaulkner
force-pushed
the
optional-filter
branch
from
5fd30ef
to
69d8afa
Compare
|
changelog detected ✅ |
1 similar comment
|
changelog detected ✅ |
jacobbednarz
changed the base branch from
master
to
dependabot/go_modules/github.com/cloudflare/cloudflare-go-0.42.0
jacobbednarz
merged commit ba9c132
into
cloudflare:dependabot/go_modules/github.com/cloudflare/cloudflare-go-0.42.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR changes the usage of LogpushJob.Filter after the fix in cloudflare/cloudflare-go#937