This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
LogpushJob.Filter is optional #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfaulkner
requested review from
yknx4,
a team and
andrew-jung
and removed request for
a team
sbfaulkner
added a commit
that referenced
this pull request
Jun 20, 2022
sbfaulkner
force-pushed
the
optional-filter-shopify
branch
from
6bd95c5
to
e090fee
Compare
|
@yknx4 I've disabled the Changelog check workflow on our fork -- I think that makes sense since it will get checked upstream when we PR there - wdyt? |
sbfaulkner
force-pushed
the
optional-filter-shopify
branch
from
e090fee
to
5c4fe3e
Compare
joshuamsager
approved these changes
Jun 20, 2022
yknx4
approved these changes
Jun 20, 2022
|
@sbfaulkner It totally makes sense to disable it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
early availability PR while we wait for cloudflare/cloudflare-go#937 and then cloudflare#1712 to land in a release
LogpushJob.Filter is a pointer now
question... are there integrations we should disable on our fork? -- eg. the changelog check