fix flaky TestFilesAreNonblocking on CI #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI runs test with stdin closed, which leads our victim cat process to exit quickly. Depending on the ordering of events we might see the test fail. Change the contract for newOSProcess to include stdin, stdout and stderr and allocate a blocking pipe as stdin for the test.
lmb
force-pushed
the
fix-test-with-closed-stdin
branch
from
670118b
to
293fa4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI runs test with stdin closed, which leads our victim cat process
to exit quickly. Depending on the ordering of events we might see
the test fail. Change the contract for newOSProcess to include
stdin, stdout and stderr and allocate a blocking pipe as stdin for
the test.