Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix flaky TestFilesAreNonblocking on CI
CI runs test with stdin closed, which leads our victim cat process to exit quickly. Depending on the ordering of events we might see the test fail. Change the contract for newOSProcess to include stdin, stdout and stderr and allocate a blocking pipe as stdin for the test.
- Loading branch information
Showing
4 changed files
with
26 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters