Add support for text_blobs
#228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Mar 30, 2022
There was a problem hiding this comment.
Looks pretty bang on to me! 🙂Added a few comments. If you could add some tests here too that would be awesome: https://github.com/cloudflare/miniflare/blob/master/packages/core/test/plugins/bindings.spec.ts.
mrbbot
reviewed
Mar 30, 2022
mrbbot
reviewed
Mar 30, 2022
mrbbot
reviewed
Mar 30, 2022
mrbbot
reviewed
Mar 30, 2022
Comment on lines
326
to
328
| textBlobBindings: { | ||
| D: loremIpsumPath, | ||
| }, |
There was a problem hiding this comment.
The idea with this test is that the lowest priority binding defines the most bindings, that are then overriden by subsequent higher priority bindings. For textBlobBindings, you'd want to define A, B, C as loremIpsumPath, for wasmBindings you'd define A, B, C, D, for envPath you'd define A=env\nB=env\nC=env\nD=env\nE=env and then for wrangler bindings you'd define A, B, C, D, E, F.
This is probably a little excessive, but it's nice to test every combination 🙂
added 2 commits
March 30, 2022 08:39
mrbbot
approved these changes
Mar 30, 2022
Closed
threepointone
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 31, 2022
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
threepointone
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 31, 2022
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
threepointone
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 31, 2022
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
threepointone
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 31, 2022
This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
threepointone
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Mar 31, 2022
…ode (#735) This adds support for `text_blobs`/Text module support in local mode. Now that cloudflare/miniflare#228 has landed in miniflare (thanks @caass!), we can use that in wrangler as well. Fixes #416
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have absolutely no idea what I'm doing here 😎
Opening in hope of closing #211