implement [data_blobs]
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
commented
Apr 1, 2022
threepointone
commented
Apr 1, 2022
threepointone
force-pushed
the
data-blobs
branch
from
4d71297
to
74d60bf
Compare
threepointone
commented
Apr 1, 2022
mrbbot
reviewed
Apr 2, 2022
threepointone
force-pushed
the
data-blobs
branch
from
74d60bf
to
fc3eea1
Compare
This implements support for `[data_blobs]` for service workers, which lets you bind some data from a file as an ArrayBuffer in service-worker format workers. It also adds a `--data-blob` cli argument for the same.
threepointone
force-pushed
the
data-blobs
branch
from
fc3eea1
to
ee8ce0f
Compare
|
Hoping to get a release out today btw 🤞 |
|
!! That would be amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements support for
[data_blobs]for service workers, which lets you bind some data from a file as an ArrayBuffer in service-worker format workers. It also adds a--data-blobcli argument for the same.Fixes #231
I implemented this mechanically by mirroring the implementation from
text_blobsin #228. Happy to iterate!