Skip to content

Commit

Permalink
Bump undici version and minimum node version (#333)
Browse files Browse the repository at this point in the history
* Bump undici version and minimum node version

To target security vulnerabilities in undici, we update to the latest version.

From undici v5.7.0, we require a node >=16.8.0 - here we update the minimum to 16.13.0 (the first Node 16 LTS release)

* Pin undici version

We should pin the version of undici

* Wrap `Body#formData()` `Buffer` chunks in `Uint8Array`s

Workaround for nodejs/undici#1601

* Delay freed check in `HTMLRewriter` `ArrayBuffer(View)` chunk test

Co-authored-by: MrBBot <me@mrbbot.dev>
  • Loading branch information
cameron-robey and mrbbot committed Aug 15, 2022
1 parent 5a48285 commit 7894fa4
Show file tree
Hide file tree
Showing 31 changed files with 87 additions and 85 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Expand Up @@ -7,9 +7,9 @@ name: Test

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches: [ master ]
branches: [master]

jobs:
test:
Expand All @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node: [16.7.0, 18.x]
node: [16.13.0, 18.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
2 changes: 1 addition & 1 deletion docs/src/content/get-started/cli.md
Expand Up @@ -32,7 +32,7 @@ $ npx miniflare

<Aside type="warning" header="Warning">

Miniflare requires at least **Node.js 16.7.0**, as it makes extensive use of
Miniflare requires at least **Node.js 16.13.0**, as it makes extensive use of
recently added web standards. You should use the latest Node.js version if
possible, as Cloudflare Workers use a very up-to-date version of V8. Consider
using a Node.js version manager such as https://volta.sh/ or
Expand Down
2 changes: 1 addition & 1 deletion docs/src/content/get-started/migrating.md
Expand Up @@ -11,7 +11,7 @@ guide walks you through how to upgrade your app.

### Upgrade Node.js

**Node.js 16.7.0 is now the minimum required version**. You should use the
**Node.js 16.13.0 is now the minimum required version**. You should use the
latest Node.js version if possible, as Cloudflare Workers use a very up-to-date
version of V8. Consider using a Node.js version manager such as
<https://volta.sh/> or <https://github.com/nvm-sh/nvm>.
Expand Down
86 changes: 43 additions & 43 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7894fa4

Please sign in to comment.