Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClasspathElementDir review adjustments #851

Merged
merged 2 commits into from
Apr 19, 2024
Merged

ClasspathElementDir review adjustments #851

merged 2 commits into from
Apr 19, 2024

Commits on Apr 19, 2024

  1. Use file attributes cache when checking subdirectories 

    The file attributes at this point have already been requested in
order to check whether the subPath is a regular file and so there
is no need for an additional isDir call.
    Attila Puskas committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9bf48dc View commit details
    Browse the repository at this point in the history

  2. Use Iterator.remove instead of List copy 

    To point is that when we already know from some paths to be just
regular files, but not directories then at the end we do not need
to check if these are directories. But rather than copying the
list we can use iterators to remove the already discovered files.
    Attila Puskas committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3d2ebc2 View commit details
    Browse the repository at this point in the history