ClasspathElementDir review adjustments #851
Conversation
The file attributes at this point have already been requested in order to check whether the subPath is a regular file and so there is no need for an additional isDir call.
To point is that when we already know from some paths to be just regular files, but not directories then at the end we do not need to check if these are directories. But rather than copying the list we can use iterators to remove the already discovered files.
|
LGTM. Thanks! |
|
Released in 4.8.172. |
|
Thanks! |
|
I opened a bug about that. There's some nondeterminism in the classpath resolution order which is not supposed to be there (the order is supposed to be deterministic, despite parallel scanning). I don't know what could cause that, and it's going to be a hard bug to get to the bottom of. I don't have the time to look into it right now. But if you look at the failing test, you might be able to figure it out. The issue occurs when a classpath element adds additional classpath elements to the scan, partway through the scan. Specifically, when a manifest has a Class-Path entry. |
|
I see, thanks for the detailed explanation! |
Based on the following comments:
#850 (comment)
#850 (comment)