Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move off of HashMap/IndexMap to flat containers #4065

Merged
merged 3 commits into from
Aug 11, 2022
Merged

refactor: Move off of HashMap/IndexMap to flat containers #4065

merged 3 commits into from
Aug 11, 2022

Commits on Aug 11, 2022

  1. refactor: Move off of IndexSet/HashSet 

    This dropped `.text` by 14KB

Anything in debug asserts or help/usage output doesn't matter for
performance but I wouldn't be surprised if this was comparable since the
container sizes we are talking about are relatively small.
    @epage
    epage committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d441ebb View commit details
    Browse the repository at this point in the history

  2. refactor: Move off of IndexMap/HashMap 

    This dropped 17KB

Again, performance shouldn't be too bad as the total number of argument
id's passed in by the user shouldn't be huge, with the upper end being
5-15 except for in extreme cases like rustc accepting arguments from
cargo via a file.
    @epage
    epage committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6e7fd6d View commit details
    Browse the repository at this point in the history

  3. docs: Fix for 1.63

    @epage
    epage committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e7ced88 View commit details
    Browse the repository at this point in the history