refactor: Move off of HashMap/IndexMap to flat containers #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dropped `.text` by 14KB Anything in debug asserts or help/usage output doesn't matter for performance but I wouldn't be surprised if this was comparable since the container sizes we are talking about are relatively small.
This dropped 17KB Again, performance shouldn't be too bad as the total number of argument id's passed in by the user shouldn't be huge, with the upper end being 5-15 except for in extreme cases like rustc accepting arguments from cargo via a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the number of items we manage, straight iteration is probably fast enough or faster and this reduces the amount of memory we use.
The map is modeled after the proposed version in C++ so that the keys are more likely to be in cache lines. If we ever add sorting to this, it'll get messy though. Since this is all internal, direct types are exposed rather than newtypes.
This is a good step towards #1365. The
.textsize dropped by 30.8KB according to$ cargo bloat --features cargo --example cargo-example --releaseWhile I didn't measure build times, things should be improved for #2037 because we are sending less code to LLVM.