Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(parser): Extract Actions from Parser #3773

Merged
merged 19 commits into from May 31, 2022
Merged

refactor(parser): Extract Actions from Parser #3773

merged 19 commits into from May 31, 2022

Commits on May 27, 2022

  1. refactor(parser): Normalize Arg variable names

    @epage
    epage committed May 27, 2022
    Configuration menu
    Copy the full SHA
    e4271d0 View commit details
    Browse the repository at this point in the history

  2. refactor(parser): Separate delimiting from storing

    @epage
    epage committed May 27, 2022
    Configuration menu
    Copy the full SHA
    7b6bb32 View commit details
    Browse the repository at this point in the history

  3. refactor(parser): Generalize the performing of actions

    @epage
    epage committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b862fe2 View commit details
    Browse the repository at this point in the history

  4. refactor(parser): Extract an occurrence into a reaction

    @epage
    epage committed May 27, 2022
    Configuration menu
    Copy the full SHA
    e1c5cba View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. refactor(parser): Match default_missing_vals to rest

    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f0b2924 View commit details
    Browse the repository at this point in the history

  2. refactor(parser); Switch default_missing_vals to actions

    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a98075e View commit details
    Browse the repository at this point in the history

  3. refactor(parser): Switch defaults/envs to actions 

    There is a default_missing_vals case which is slightly different because
its not actually a default but closing out the remaining argument that
was started in last iteration.
    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    dc8a7d4 View commit details
    Browse the repository at this point in the history

  4. refactor(parser): Be more explicit that default missing values is not… 

    … escaped
    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    2d8a154 View commit details
    Browse the repository at this point in the history

  5. refactor(parser): Don't track the actual identifier 

    When creating `PendingValues`, I can't have the lifetime.  I could make
it a `Cow` but decided to hold off instead since we don't need this
right now.  Maybe by the time we do need it, we'll have another way of
doing this.
    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    0b5de21 View commit details
    Browse the repository at this point in the history

  6. refactor(parser): Allow more match-state

    @epage
    epage committed May 28, 2022
    Configuration menu
    Copy the full SHA
    6f5aaab View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. refactor(parser): Switch positionals to actions

    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    bf7259d View commit details
    Browse the repository at this point in the history

  2. test(parser): Verify interleaved group behavior

    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    bba83cb View commit details
    Browse the repository at this point in the history

  3. refactor(parser)!: Switch flag values to Actions 

    This changes how occurrences and values are grouped for multiple values.
Today, it appears as a bug.  If we move forward with clap-rs#3772, then this
can make sense.
    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    f2a219e View commit details
    Browse the repository at this point in the history

  4. fix(parser): Restore interleaved positional behavior 

    If we felt this was important long-term, we should fix this outside of
the Action.  Since we might be changing up occurrences (clap-rs#3772), we can
probably get away with a hack.
    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    cb6f7b7 View commit details
    Browse the repository at this point in the history

  5. fix(parser): Qualify the type of action 

    My hope is to add group actions as well, so we need to qualify what kind
of action this is.
    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    c052a97 View commit details
    Browse the repository at this point in the history

  6. fix(parser): Restore positional occurrence behavior 

    This fixes a compatibility issue introduced in 9805fda
    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    5a55f4a View commit details
    Browse the repository at this point in the history

  7. refactor(parser): Be explicit about not not iterating over every value

    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    70b633b View commit details
    Browse the repository at this point in the history

  8. style: Fix debug typoe

    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    12d145c View commit details
    Browse the repository at this point in the history

  9. style: Make clippy happy

    @epage
    epage committed May 31, 2022
    Configuration menu
    Copy the full SHA
    8af7294 View commit details
    Browse the repository at this point in the history