refactor(parser): Extract Actions from Parser #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a default_missing_vals case which is slightly different because its not actually a default but closing out the remaining argument that was started in last iteration.
When creating `PendingValues`, I can't have the lifetime. I could make it a `Cow` but decided to hold off instead since we don't need this right now. Maybe by the time we do need it, we'll have another way of doing this.
This changes how occurrences and values are grouped for multiple values. Today, it appears as a bug. If we move forward with clap-rs#3772, then this can make sense.
If we felt this was important long-term, we should fix this outside of the Action. Since we might be changing up occurrences (clap-rs#3772), we can probably get away with a hack.
My hope is to add group actions as well, so we need to qualify what kind of action this is.
This fixes a compatibility issue introduced in 9805fda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not publicly exposed yet and is a step towards #3405. Nearly all storing of data into
ArgMatchesis extracted into areactfunction that is based on anActionenum associated with theArg. I said "nearly" because we can't quite do this for external subcommand values.The parser iterates once per argv field. This presented a problem for flags with values and multi-valued positionals. We handle this by tracking "pending" values and resolving them before reacting to the current value. This comes at some behavior changes for
ArgMatches::occurrences_ofthat could be fine for future versions of the actions though we should reconsider this before release.