Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove strict linting from generated code #4739

Merged
merged 1 commit into from Feb 28, 2023

Conversation

MingweiSamuel
Copy link
Contributor

@MingweiSamuel MingweiSamuel commented Feb 28, 2023

fix #4733

Removes #[deny(clippy::correctness)] from generated code, added in #1726

Macros really shouldn't be making lints stricter, just causes more noise in user code when they're triggered. Macro code naturally will have lint false positives

@epage
Copy link
Member

epage commented Feb 28, 2023

Agreed that we shouldn't make the lints stricter. We have CI to make sure that any lints that are generated get denied.

@epage epage merged commit 70818c3 into clap-rs:master Feb 28, 2023
20 checks passed
hds added a commit to hds/clap that referenced this pull request Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such
as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering
a clippy error in some uses. Due to the placement of the `deny`, it is
not possible for a user of clap to override it.

This change removes all the instances of this `deny` attribute. The same
was done on the `master` branch in clap-rs#4739.

Fixes: 4857
hds added a commit to hds/clap that referenced this pull request Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such
as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering
a clippy error in some uses. Due to the placement of the `deny`, it is
not possible for a user of clap to override it.

This change removes all the instances of this `deny` attribute. The same
was done on the `master` branch in clap-rs#4739.

Fixes: clap-rs#4857
hds added a commit to hds/clap that referenced this pull request Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such
as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering
a clippy error in some uses. Due to the placement of the `deny`, it is
not possible for a user of clap to override it.

This change removes all the instances of this `deny` attribute. The same
was done on the `master` branch in clap-rs#4739.

Fixes: clap-rs#4857
hds added a commit to hds/clap that referenced this pull request Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such
as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering
a clippy error in some uses. Due to the placement of the `deny`, it is
not possible for a user of clap to override it.

This change removes all the instances of this `deny` attribute. The same
was done on the `master` branch in clap-rs#4739.

Fixes: clap-rs#4857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::almost_swapped check failing on latest nightly
2 participants