Bump clap to 4.2.5

[altaua]

We need a clap version incorporating clap-rs/clap#4739 to work around a Rust 1.69.0 clippy bug.

As far as I can see in the clap release notes, there have been no relevant changes between clap 4.0.9 and 4.2.5 that'd require any action on our side.

Prerequisite of https://github.com/paritytech/ci_cd/issues/789

polkadot companion: paritytech/polkadot#7160
cumulus companion: paritytech/cumulus#2505

[coderobe]

i recall a previous clap bump subtly breaking behaviour that was being relied on - this should probably be smoke-tested locally

[bkchr]

Please update the Cargo.toml files here in Substrate.

[altaua]

Please update the Cargo.toml files here in Substrate.

Can do, but why? I'm just updating clap because it's useful for CI, but the new version isn't strictly required by the substrate code.

[altaua]

i recall a previous clap bump subtly breaking behaviour that was being relied on - this should probably be smoke-tested locally

Our testsuites run fine and the changelog sounds reasonable; do you have anything in particular you'd like tested beyond that?

[bkchr]

Please update the Cargo.toml files here in Substrate.

Can do, but why? I'm just updating clap because it's useful for CI, but the new version isn't strictly required by the substrate code.

Because otherwise the changes here are not required. As you already have done it downstream.

[bkchr]

Others will also run into the issues with the latest rust version, but if we bump here the versions in the Cargo.toml they would get these changes "for free" in the downstream projects.

[ggwpez]

bot rebase

CI was red.

[paritytech-processbot]

Rebased

[altaua]

bot merge

[paritytech-processbot]

Waiting for commit status.