fix: Remove strict linting from generated code #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
force-pushed
the
v3-no-deny-correctness
branch
from
821cdde
to
37b1266
Compare
hds
changed the title
|
@epage It seems like there are some unrelated test and doc checks that are failing. Perhaps this is too complicated and I should focus on upgrading to clap 4? (-; |
|
If you rebase, most of the problems should go away |
The `#[deny(correctness)]` attribute is inside some generated code (such as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering a clippy error in some uses. Due to the placement of the `deny`, it is not possible for a user of clap to override it. This change removes all the instances of this `deny` attribute. The same was done on the `master` branch in clap-rs#4739. Fixes: clap-rs#4857
hds
force-pushed
the
v3-no-deny-correctness
branch
from
37b1266
to
f14f398
Compare
|
That's fixed most of them, just seem to be having some issues with the docs. |
|
Yeah, I've not reproduced it locally and its a warning, turned error, so it shouldn't actually block anything, so I'm willing to go forward with this |
|
Released v3.2.24 |
|
Thank you very much @epage! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#[deny(correctness)]attribute is inside some generated code (suchas the
Subcommandderive macro). As of Rust 1.69.0, this is triggeringa clippy error in some uses. Due to the placement of the
deny, it isnot possible for a user of clap to override it.
This change removes all the instances of this
denyattribute. The samewas done on the
masterbranch in #4739.Fixes: #4857