ci: remove workaround for incompatibility between lerna@7 and npm@9 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lerna cannot bump versions due to incompatibility of the lock file, so it was ignored during the version bumping. This workaround introduced a bug mentioned at #389 Now I've tried to bump versions without ignoring the lock file and it works, so the workaround is simply removed by this commit. Ref: lerna/lerna#3418 (comment)
yanguoyu
approved these changes
Jul 27, 2023
Daryl-L
approved these changes
Jul 28, 2023
Codecov Report
@@ Coverage Diff @@
## develop #398 +/- ##
========================================
Coverage 62.39% 62.39%
========================================
Files 94 94
Lines 3101 3101
Branches 688 688
========================================
Hits 1935 1935
Misses 1057 1057
Partials 109 109 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lerna cannot bump versions due to incompatibility of the lock file, so it was ignored during the version bumping.
This workaround introduced a bug mentioned at #389
Now I've tried to bump versions without ignoring the lock file and it works, so the workaround is simply removed by this commit.
Ref: lerna/lerna#3418 (comment)