Skip to content

Commit

Permalink
ci: remove workaround for incompatibility between lerna@7 and npm@9 (#…
Browse files Browse the repository at this point in the history
…398)

Lerna cannot bump versions due to incompatibility of the lock
file, so it was ignored during the version bumping.

This workaround introduced a bug mentioned at #389

Now I've tried to bump versions without ignoring the lock file
and it works, so the workaround is simply removed by this commit.

Ref: lerna/lerna#3418 (comment)
  • Loading branch information
Keith-CY committed Jul 28, 2023
1 parent 6c3fcc1 commit 6820b80
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/bump-version.yml
Expand Up @@ -22,11 +22,6 @@ jobs:
with:
node-version: 18.x

# this is a patch for incompatibility between lerna@7 and npm@9 https://github.com/lerna/lerna/issues/3418#issuecomment-1337756237
- name: Remove lock file
if: env.IS_RC_BRANCH == 'true'
run: rm package-lock.json

- name: Get version number
if: env.IS_RC_BRANCH == 'true'
id: version-number
Expand Down Expand Up @@ -64,4 +59,3 @@ jobs:
body: ${{ steps.changelog.outputs.changelog }}
committer: Chen Yu <chenyu@magickbase.com>
branch: chore-update-version-for-${{ github.ref_name }}
add-paths: ':!package-lock.json'

0 comments on commit 6820b80

Please sign in to comment.