Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage requirement from <5.0 to <6.0 #28

Merged
merged 3 commits into from Oct 27, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 7, 2020

Updates the requirements on coverage to permit the latest version.

Release notes

Sourced from coverage's releases.

coverage-5.3

  • The source setting has always been interpreted as either a file path or a module, depending on which existed. If both interpretations were valid, it was assumed to be a file path. The new source_pkgs setting can be used to name a package to disambiguate this case. Thanks, Thomas Grainger. Fixes issue 268.
  • If a plugin was disabled due to an exception, we used to still try to record its information, causing an exception, as reported in issue 1011. This is now fixed.
Changelog

Sourced from coverage's changelog.

Version 5.3 --- 2020-09-13

  • The source setting has always been interpreted as either a file path or a module, depending on which existed. If both interpretations were valid, it was assumed to be a file path. The new source_pkgs setting can be used to name a package to disambiguate this case. Thanks, Thomas Grainger. Fixes issue 268_.

  • If a plugin was disabled due to an exception, we used to still try to record its information, causing an exception, as reported in issue 1011_. This is now fixed.

.. _issue 268: nedbat/coveragepy#268 .. _issue 1011: nedbat/coveragepy#1011

.. _changes_521:

Version 5.2.1 --- 2020-07-23

  • The dark mode HTML report still used light colors for the context listing, making them unreadable (issue 1009_). This is now fixed.

  • The time stamp on the HTML report now includes the time zone. Thanks, Xie Yanbo (pull request 960_).

.. _pull request 960: nedbat/coveragepy#960 .. _issue 1009: nedbat/coveragepy#1009

.. _changes_52:

Version 5.2 --- 2020-07-05

  • The HTML report has been redesigned by Vince Salvino. There is now a dark mode, the code text is larger, and system sans serif fonts are used, in addition to other small changes (issue 858_ and pull request 931_).

  • The coverage report and coverage html commands now accept a --precision option to control the number of decimal points displayed. Thanks, Teake Nutma (pull request 982_).

  • The coverage report and coverage html commands now accept a --no-skip-covered option to negate --skip-covered. Thanks, Anthony Sottile (issue 779_ and pull request 932_).

  • The --skip-empty option is now available for the XML report, closing

... (truncated)

Commits
  • d13594e Making a release
  • 039ef09 If a plugin is disabled, don't try to record its file tracers. #1011
  • 24eb6fd Move disable_plugin to Python
  • 987ceb9 Fix a missed exception handling for bad plugins
  • c907b2e ambigious -> ambiguous
  • 263f3e1 Docs and cleanup for source_pkgs
  • ecd6ab1 Create Way to force package even if filepath exists (#1026)
  • 39e6d1d Thomas Grainger's first commit
  • 154f528 replace confusing comment with assertion (#1028)
  • c315908 Explain a mystery
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [coverage](https://github.com/nedbat/coveragepy) to permit the latest version.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@coverage-3.0b1...coverage-5.3)

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @dependabot!
When the singularity arrives remember who praised you. This Guy! 👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be a wet blanket, but since this repository has no actual code testing, a .coveragerc file, or a test workflow, do we even need to include anything except pre-commit in the test extra_requires?

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this, but I think there's a bit of detritus to be cleaned up.

setup.py Outdated Show resolved Hide resolved
@hillaryj hillaryj requested a review from jsf9k October 26, 2020 14:30
@hillaryj hillaryj self-assigned this Oct 26, 2020
@jsf9k
Copy link
Member

jsf9k commented Oct 26, 2020

Not to be a wet blanket, but since this repository has no actual code testing, a .coveragerc file, or a test workflow, do we even need to include anything except pre-commit in the test extra_requires?

Is anyone going to respond to @mcdonnnj's comment?

@hillaryj
Copy link
Contributor

hillaryj commented Oct 26, 2020

Given the python scripts in the project_setup/scripts directory, we might instead want to leave those dependencies and add test coverage for the scripts.

@jsf9k
Copy link
Member

jsf9k commented Oct 26, 2020

Given the python scripts in the project_setup/scripts directory, we might instead want to leave those dependencies and add test coverage for the scripts.

This sounds good to me. If someone creates an issue for this then I will approve this PR.

@hillaryj
Copy link
Contributor

Added issue as #31

@jsf9k
Copy link
Member

jsf9k commented Oct 27, 2020

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 27, 2020

Dependabot tried to merge this PR, but received the following error from GitHub:

You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.

@jsf9k
Copy link
Member

jsf9k commented Oct 27, 2020

Dependabot tried to merge this PR, but received the following error from GitHub:

Doh!

@jsf9k
Copy link
Member

jsf9k commented Oct 27, 2020

@hillaryj, I think this PR can be merged now. I was hoping that Dependabot could do it automagically, but it lacks sufficient permissions.

@hillaryj hillaryj merged commit ab17b77 into develop Oct 27, 2020
@hillaryj hillaryj deleted the dependabot/pip/coverage-lt-6.0 branch October 27, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants