replace confusing comment with assertion #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Sep 2, 2020
Comment on lines
+907
to
+913
| def test_source_package_dotted_sub(self): | ||
| lines = self.coverage_usepkgs(source=["pkg1.sub"]) | ||
| self.filenames_not_in(lines, "p2a p2b othera otherb osa osb") | ||
| # Because source= was specified, we do search for unexecuted files. | ||
| self.assertEqual(lines['runmod3'], 0) | ||
|
|
||
| def test_source_package_dotted(self): | ||
| def test_source_package_dotted_p1b(self): |
There was a problem hiding this comment.
@nedbat I'm not really clear what the difference between these two tests is
There was a problem hiding this comment.
pkg1.sub is a directory, pkg1.p1b is a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.