Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CollectionSpec.RewriteMaps() #651

Merged
merged 3 commits into from May 3, 2022
Merged

Deprecate CollectionSpec.RewriteMaps() #651

merged 3 commits into from May 3, 2022

Commits on May 2, 2022

  1. coll: reword MapReplacements 

    Signed-off-by: Timo Beckers <timo@isovalent.com>
    @ti-mo
    ti-mo committed May 2, 2022
    Configuration menu
    Copy the full SHA
    6846ff0 View commit details
    Browse the repository at this point in the history

  2. coll: move replacement map compatibility check to newCollectionLoader 

    We want to make sure to ensure compatibility of all Maps passed in
opts.MapReplacements, not just the ones that get loaded using `loadMap`
later on. This avoids any surprises down the line.

Signed-off-by: Timo Beckers <timo@isovalent.com>
    @ti-mo
    ti-mo committed May 2, 2022
    Configuration menu
    Copy the full SHA
    9f3cdaa View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. coll: deprecate cs.RewriteMaps in favor of CollectionOptions.MapRepla… 

    …cements

Signed-off-by: Timo Beckers <timo@isovalent.com>
    @ti-mo
    ti-mo committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b08b20d View commit details
    Browse the repository at this point in the history