Deprecate CollectionSpec.RewriteMaps() #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Beckers <timo@isovalent.com>
We want to make sure to ensure compatibility of all Maps passed in opts.MapReplacements, not just the ones that get loaded using `loadMap` later on. This avoids any surprises down the line. Signed-off-by: Timo Beckers <timo@isovalent.com>
lmb
reviewed
May 3, 2022
lmb
approved these changes
May 3, 2022
ti-mo
force-pushed
the
tb/deprecate-rewrite-maps
branch
from
bf9430b
to
6c96db1
Compare
…cements Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/deprecate-rewrite-maps
branch
from
6c96db1
to
b08b20d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some follow-ups to #646.
Adds a deprecation notice to RewriteMaps().
Moves the Map(Spec) compatibility check out of the lazy-loading path.
cc @mauriciovasquezbernal