Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search chrome binary in different locations on different OS systems. #811

Merged
merged 2 commits into from May 4, 2021
Merged

Search chrome binary in different locations on different OS systems. #811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3294339
Perform different chrome binary searches depending on OS runtime.
fabio42 May 3, 2021
93d06b6
Refactor variables names
fabio42 May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
64 changes: 38 additions & 26 deletions allocate.go
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ import (
"os"
"os/exec"
"path/filepath"
"runtime"
"sync"
"time"
)
Expand Down Expand Up @@ -325,33 +326,44 @@ func ExecPath(path string) ExecAllocatorOption {
}

// findExecPath tries to find the Chrome browser somewhere in the current
// system. It performs a rather agressive search, which is the same in all
// systems. That may make it a bit slow, but it will only be run when creating a
// new ExecAllocator.
// system. Different searches are performed depending on OS runtime.
fabio42 marked this conversation as resolved.
Show resolved Hide resolved
// It could perform a rather aggressive search. That may make it a bit slow,
// but it will only be run when creating a new ExecAllocator.
func findExecPath() string {
for _, path := range [...]string{
// Unix-like
"headless_shell",
"headless-shell",
"chromium",
"chromium-browser",
"google-chrome",
"google-chrome-stable",
"google-chrome-beta",
"google-chrome-unstable",
"/usr/bin/google-chrome",

// Windows
"chrome",
"chrome.exe", // in case PATHEXT is misconfigured
`C:\Program Files (x86)\Google\Chrome\Application\chrome.exe`,
`C:\Program Files\Google\Chrome\Application\chrome.exe`,
filepath.Join(os.Getenv("USERPROFILE"), `AppData\Local\Google\Chrome\Application\chrome.exe`),

// Mac
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
} {
found, err := exec.LookPath(path)
var path []string
fabio42 marked this conversation as resolved.
Show resolved Hide resolved
switch runtime.GOOS {
case "darwin":
path = []string{
// Mac
"/Applications/Chromium.app/Contents/MacOS/Chromium",
"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
}
case "windows":
path = []string{
// Windows
"chrome",
"chrome.exe", // in case PATHEXT is misconfigured
`C:\Program Files (x86)\Google\Chrome\Application\chrome.exe`,
`C:\Program Files\Google\Chrome\Application\chrome.exe`,
filepath.Join(os.Getenv("USERPROFILE"), `AppData\Local\Google\Chrome\Application\chrome.exe`),
}
default:
path = []string{
// Unix-like
"headless_shell",
"headless-shell",
"chromium",
"chromium-browser",
"google-chrome",
"google-chrome-stable",
"google-chrome-beta",
"google-chrome-unstable",
"/usr/bin/google-chrome",
}
}

for _, p := range path {
fabio42 marked this conversation as resolved.
Show resolved Hide resolved
found, err := exec.LookPath(p)
if err == nil {
return found
}
Expand Down