Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search chrome binary in different locations on different OS systems. #811

Merged
merged 2 commits into from May 4, 2021
Merged

Search chrome binary in different locations on different OS systems. #811

merged 2 commits into from May 4, 2021

Commits on May 3, 2021

  1. Perform different chrome binary searches depending on OS runtime. 

    This change provides a slightly more efficient way of
discovering the `chrome` binary path. It also solves
a discovery issue on `darwin` OS when `chromium` is
installed through `homebrew` chromedp#752.
    @fabio42
    fabio42 committed May 3, 2021
    Copy the full SHA
    3294339 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Refactor variables names

    @fabio42
    fabio42 committed May 4, 2021
    Copy the full SHA
    93d06b6 View commit details
    Browse the repository at this point in the history