Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock in TestPrematureCancel. #742

Closed
wants to merge 1 commit into from
Closed

Fix deadlock in TestPrematureCancel. #742

wants to merge 1 commit into from

Commits on Jan 15, 2021

  1. Fix deadlock in TestPrematureCancel. 

    The `c.allocated` channel is only written in `NewContext`, and
subsequently closed when the browser is allocated. But the browser is
allocated in `Run` and this test calls `Cancel` before `Run`, so the
channel couldn't possible receive any more data nor be closed for a
second read to not block.
    @QuLogic
    QuLogic committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    253578b View commit details
    Browse the repository at this point in the history