Fix deadlock in TestPrematureCancel. #742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `c.allocated` channel is only written in `NewContext`, and subsequently closed when the browser is allocated. But the browser is allocated in `Run` and this test calls `Cancel` before `Run`, so the channel couldn't possible receive any more data nor be closed for a second read to not block.
|
Greatly appreciated! Added to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
c.allocatedchannel is only written inNewContext, and subsequently closed when the browser is allocated. But the browser is allocated inRunand this test callsCancelbeforeRun, so the channel couldn't possible receive any more data nor be closed for a second read to not block.Fixes #675.