allow backslash in string, fixes issue #45 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for your contribution! You will need to rebase this change before we can merge it. Tim @mithro Ansell |
christian-lanius
force-pushed
the
escaped_character_fix
branch
from
476bfad
to
f8c73bd
Compare
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
christian-lanius
force-pushed
the
escaped_character_fix
branch
from
f8c73bd
to
5f706d1
Compare
mithro
reviewed
Apr 6, 2021
|
Yeah, I am currently attempting to figure out what to do with them. They are not empty (as they exist in the repo), but their mode has changed. I'll ping you once I have figured it out. |
kgugala
reviewed
Apr 6, 2021
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
Signed-off-by: Christian Lanius <christian.lanius@rwth-aachen.de>
christian-lanius
force-pushed
the
escaped_character_fix
branch
from
3513c57
to
9ad24f9
Compare
|
@kgugala Alright, I fixed the string definition as well as the file mode for the two scripts which I did not touch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue reported in #45 by adding the literal \ (backslash) to the definition of the type STRING. I could not find specifically if "port_instance" in the spec allows for this, but commerical EDA tools support it across the board (and generate such files), thus this library should support it as well.
I have added a testcase in the escaped_name.sdf file, which has crashed before, but has been fixed by the change.
Signed-off-by: Christian Lanius christian.lanius@rwth-aachen.de