Issue #7802: Resolve Pitest Issues - CustomImportOrderCheck (1) #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wltan
force-pushed
the
customimport-pitest1-improved
branch
from
75675f7
to
88bb89b
Compare
strkkk
approved these changes
Mar 11, 2020
rnveach
requested changes
Mar 11, 2020
src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheckTest.java
Outdated
Show resolved
Hide resolved
wltan
force-pushed
the
customimport-pitest1-improved
branch
3 times, most recently
from
ca52e6d
to
2bb5be6
Compare
wltan
force-pushed
the
customimport-pitest1-improved
branch
from
2bb5be6
to
beee255
Compare
rnveach
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7802 (comment) it was found that the current unit tests are not well-designed to kill the mutations produced by pitest. Copied here for reference:
This PR aims to address that problem by enhancing the existing unit tests.
Pitest report for this branch: https://wltan.github.io/checkstyle-reports/2020-03-12/202003121402/
Both lines 815 and 816 no longer cause issues under pitest. It appears that this PR can solve both #7802 and #7806 at the same time.