Resolve Pitest Issues - CustomImportOrderCheck (5)

[rnveach]

Child issue of #7797 ,

checkstyle/.ci/pitest.sh

Line 81 in abf829f

"CustomImportOrderCheck.java.html:<td class='covered'><pre><span class='survived'> || length == betterMatchCandidate.matchLength</span></pre></td></tr>"

[wltan]

I am on it. Claiming this as well because it appears to be very closely related to #7802.

• Both issues are part of a single boolean expression
• They are connected by a && operator and the mutations survive when either one is hardcoded to false, so any fix is likely to affect both issues at once

[wltan]

Pitest report:
https://wltan.github.io/checkstyle-reports/2020-03-11/customimport-pitest1/com.puppycrawl.tools.checkstyle.checks.imports/CustomImportOrderCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@4d2b49be_815

Surviving mutation:
removed conditional - replaced equality check with false → SURVIVED

Hardcoded mutation:
wltan@ab81da3

Even though #7802 had no discrepancies in regression, I will run it again here just to be sure that there are no additional cases. Regression:
https://wltan.github.io/checkstyle-reports/2020-03-11/pitest5-regression/diff/

No discrepancies found but see #7802 (comment) and/or #7826 for more information on possible UT cases.

[rnveach]

Fix was merged via #7802