Issue #11734: Add codenarc to CI for groovy files #11739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
12 times, most recently
from
fa9fddf
to
7941900
Compare
|
I would move this check to Travis or other not high demand CI. It it most likely that such script will never be updated after summer, so better to have it run in some less critical CI. But we can do this move at end of summer |
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
2 times, most recently
from
5e3e546
to
84c4ffa
Compare
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
5 times, most recently
from
689e450
to
618c38a
Compare
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
5 times, most recently
from
dbd55ac
to
ce4ba54
Compare
romani
approved these changes
Jun 23, 2022
Vyom-Yadav
commented
Jun 23, 2022
Comment on lines
+303
to
+276
| UnnecessaryGroovyImport { | ||
| doNotApplyToFileNames = 'codenarc.groovy' | ||
| } | ||
| UnusedImport { | ||
| doNotApplyToFileNames = 'codenarc.groovy' | ||
| } |
There was a problem hiding this comment.
False positives, those imports are used.
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
from
ce4ba54
to
3ed6748
Compare
|
@Vyom-Yadav see CI failure at https://cloud.drone.io/checkstyle/checkstyle/10876/5/2 |
Vyom-Yadav
force-pushed
the
addCodenarcToCi
branch
from
3ed6748
to
f1c2717
Compare
Done. |
nrmancuso
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11734
Failing CodeNarc analysis (Proof of working): https://github.com/checkstyle/checkstyle/runs/7021070841?check_suite_focus=true