Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codenarc to CI for groovy files #11734

Closed
nrmancuso opened this issue Jun 12, 2022 · 1 comment · Fixed by #11739
Closed

Add codenarc to CI for groovy files #11734

nrmancuso opened this issue Jun 12, 2022 · 1 comment · Fixed by #11739
Assignees
Milestone

Comments

@nrmancuso
Copy link
Member

nrmancuso commented Jun 12, 2022

Now that we are keeping groovy files in the main Checkstyle repo(after #11731), we should have a static analysis tool to make sure that we keep the same quality in Groovy code that we do for Java.

Let's add codenarc to CI execution now that we are adding groovy to main repo. Take a look at contribution to see how it is done there: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/codenarc.sh

Originally posted by @nick-mancuso in #11731 (comment)

Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 14, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 15, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 18, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 18, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 18, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 18, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 18, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 23, 2022
Vyom-Yadav added a commit to Vyom-Yadav/checkstyle that referenced this issue Jun 24, 2022
@nrmancuso
Copy link
Member Author

Closed via #11739

@nrmancuso nrmancuso added this to the 10.4 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants