Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker-framework.groovy depends too much on name of repo #12311

Closed
romani opened this issue Oct 17, 2022 · 3 comments · Fixed by #12337
Closed

checker-framework.groovy depends too much on name of repo #12311

romani opened this issue Oct 17, 2022 · 3 comments · Fixed by #12337

Comments

@romani
Copy link
Member

romani commented Oct 17, 2022

From #12232 (comment)

It seems to be the groovy script requires the top checkstyle folder of source to be named checkstyle.

.compile(".*[\\\\/](checkstyle[\\\\/]src.*\\.java):\\[(\\d+)[^]]*][^\\[]*\\[([^]]*)](.*)")

In this case, my folder was named checkstyle2 as this process takes a while to run and was starting to use 2 cloned repos to speed things up.

I don't think should be a requirement. We should look instead for src/(it|main|test)/java.

I think we can simply remove this reference, I don't think we will have files other than in our repo in plugin output.

@romani
Copy link
Member Author

romani commented Oct 22, 2022

@Vyom-Yadav , can you help us to resolve this issue ?

@nrmancuso
Copy link
Member

I will take a look at this

nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Oct 23, 2022
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Oct 24, 2022
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Oct 24, 2022
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Oct 24, 2022
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Oct 24, 2022
@romani romani added this to the 10.3.5 milestone Oct 24, 2022
@romani
Copy link
Member Author

romani commented Oct 24, 2022

Fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants