Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker-framework.groovy (generate): no output on Linux #12232

Closed
rnveach opened this issue Sep 26, 2022 · 3 comments
Closed

checker-framework.groovy (generate): no output on Linux #12232

rnveach opened this issue Sep 26, 2022 · 3 comments

Comments

@rnveach
Copy link
Member

rnveach commented Sep 26, 2022

When running groovy ./.ci/checker-framework.groovy checker-framework-nullness-optional-interning -g on linux, I get no XML output when I am expecting the tool to generate the new suppression file for me. It just ends with a build success.
Below is output:

[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ checkstyle ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 432 source files to /media/checkstyle/work/checkstyle2/target/classes
[WARNING] Unable to autodetect 'javac' path, using 'javac' from the environment.
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SwitchHandler.java:[60,15] [return] incompatible types in return.
  type of expression: null (NullType)
  method return type: @Initialized @NonNull DetailAST
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/SwitchHandler.java:[65,15] [return] incompatible types in return.
  type of expression: null (NullType)
  method return type: @Initialized @NonNull DetailAST
...
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java:[573,34] [initialization.field.uninitialized] the default constructor does not initialize field errorMessage
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java:[641,27] [initialization.field.uninitialized] the default constructor does not initialize field tree
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java:[646,34] [initialization.field.uninitialized] the default constructor does not initialize field parseErrorMessage
[WARNING] /media/checkstyle/work/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java:[655,22] [initialization.field.uninitialized] the default constructor does not initialize field firstNonTightHtmlTag
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19:30 min
[INFO] Finished at: 2022-09-26T12:51:45-04:00
[INFO] ------------------------------------------------------------------------
Build successful with no errors.
@rnveach rnveach changed the title checker-framework.grooy (generate): no output on Linux checker-framework.groovy (generate): no output on Linux Sep 26, 2022
@rnveach
Copy link
Member Author

rnveach commented Sep 26, 2022

First issue seems to be the groovy script requires the top checkstyle folder of source to be named checkstyle.
https://github.com/checkstyle/checkstyle/blob/master/.ci/checker-framework.groovy#L164
In this case, my folder was named checkstyle2 as this process takes a while to run and was starting to use 2 cloned repos to speed things up.

I don't think should be a requirement. We should look instead for src/(it|main|test)/java.

@romani
Copy link
Member

romani commented Oct 17, 2022

New location of hardcoded folder name

.compile(".*[\\\\/](checkstyle[\\\\/]src.*\\.java):\\[(\\d+)[^]]*][^\\[]*\\[([^]]*)](.*)")

I think we can simply remove this reference, I don't think we will have files other than in our repo in plugin output.

@romani
Copy link
Member

romani commented Oct 17, 2022

Original issue is fixed at 769dfbc

Second issue is moved to #12311

@romani romani closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants