Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12311: checker-framework.groovy depends too much on name of repo #12337

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

nrmancuso
Copy link
Member

Closes #12311

@nrmancuso
Copy link
Member Author

Github CI does not like renaming of project directory (I tried to prove that update works in CI, see https://github.com/checkstyle/checkstyle/actions/runs/3305843693/jobs/5456285191).

Here is proof from local:

➜  checkstyle2 git:(issue-12311) groovy ./.ci/checker-framework.groovy checker-signature-gui-units-init

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/home/nick/.sdkman/candidates/groovy/current/lib/groovy-2.5.18.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[INFO] 
[INFO] ------------------< com.puppycrawl.tools:checkstyle >-------------------
[INFO] Building checkstyle 10.3.5-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
...
/home/nick/github/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/gui/TreeTableModelAdapter.java:[61,37] [call.ui] Calling a method with UIEffect effect from a context limited to SafeEffect effects.
[WARNING] /home/nick/github/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/gui/TreeTableModelAdapter.java:[89,31] [call.ui] Calling a method with UIEffect effect from a context limited to SafeEffect effects.
[WARNING] /home/nick/github/checkstyle2/src/main/java/com/puppycrawl/tools/checkstyle/gui/TreeTableModelAdapter.java:[109,52] [call.ui] Calling a method with UIEffect effect from a context limited to SafeEffect effects.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:23 min
[INFO] Finished at: 2022-10-23T23:17:16-04:00
[INFO] ------------------------------------------------------------------------
Build successful with no errors.
➜  checkstyle2 git:(issue-12311) 



@@ -1,28 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<suppressedErrors>
<checkerFrameworkError unstable="false">
<fileName>checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/LocalizedMessage.java</fileName>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update of filename is required, since we do not include checkstyle directory any longer.

@nrmancuso nrmancuso marked this pull request as ready for review October 24, 2022 03:25
@nrmancuso nrmancuso requested a review from romani October 24, 2022 03:25
.ci/checker-framework.groovy Outdated Show resolved Hide resolved
Copy link
Member

@rnveach rnveach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me on my local

@rnveach rnveach assigned romani and unassigned rnveach Oct 24, 2022
@romani romani merged commit 28d8be3 into checkstyle:master Oct 24, 2022
@nrmancuso nrmancuso deleted the issue-12311 branch October 27, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checker-framework.groovy depends too much on name of repo
3 participants