Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointStyle false #10758

Closed
wants to merge 6 commits into from
Closed

Add pointStyle false #10758

wants to merge 6 commits into from

Conversation

puneetkathar1
Copy link
Contributor

Added feature - #10755

etimberg
etimberg reviewed Oct 6, 2022
View reviewed changes
docs/configuration/elements.md Outdated Show resolved Hide resolved
src/helpers/helpers.canvas.js Outdated Show resolved Hide resolved
@puneetkathar1
Copy link
Contributor Author

@etimberg Can you review it now?

@puneetkathar1
Copy link
Contributor Author

@etimberg String to bool converted, not sure If every place needs a bool false. Let me know if any other changes are needed, would be glad to update you. Haha :)

@kurkle
Copy link
Member

kurkle commented Oct 6, 2022

Isn't radius: 0 doing this already?

@puneetkathar1
Copy link
Contributor Author

@kurkle yes it is, but feature was requested and tagged as enhancement.
That would add more clarity and be more obvious with
pointStyle: false

etimberg
etimberg previously approved these changes Oct 6, 2022
View reviewed changes
@etimberg etimberg linked an issue Oct 7, 2022 that may be closed by this pull request
pointStyle: 'none' #10755
Closed
@puneetkathar1
Copy link
Contributor Author

@etimberg @kurkle Updated the tests, but still getting an error, maybe you could help me with that.
Chart.plugins config.options.plugins × should filter event callbacks by plugin events array Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) at <Jasmine>

@puneetkathar1
Copy link
Contributor Author

@etimberg ?

@LeeLenaleee LeeLenaleee changed the title fix-#10755 Add pointStyle false Oct 12, 2022
LeeLenaleee
LeeLenaleee reviewed Oct 12, 2022
View reviewed changes
test/fixtures/controller.line/pointStyle/indexable.js
@@ -16,11 +16,12 @@ module.exports = {
'dash',
'line',
'rect',
'false'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be

Suggested change
'false'
false

test/fixtures/controller.radar/pointStyle/indexable.js
@@ -16,11 +16,12 @@ module.exports = {
'dash',
'line',
'rect',
'false'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

test/fixtures/element.point/rotation.js
@@ -1,10 +1,10 @@
var gradient;

var datasets = ['circle', 'cross', 'crossRot', 'dash', 'line', 'rect', 'rectRounded', 'rectRot', 'star', 'triangle'].map(function(style, y) {
var datasets = ['circle', 'cross', 'crossRot', 'dash', 'line', 'rect', 'rectRounded', 'rectRot', 'star', 'triangle', 'false'].map(function(style, y) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

test/fixtures/plugin.tooltip/point-style.js
@@ -1,4 +1,4 @@
const pointStyles = ['circle', 'cross', 'crossRot', 'dash', 'line', 'rect', 'rectRounded', 'rectRot', 'star', 'triangle'];
const pointStyles = ['circle', 'cross', 'crossRot', 'dash', 'line', 'rect', 'rectRounded', 'rectRot', 'star', 'triangle', 'false'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@kurkle
Copy link
Member

kurkle commented Oct 17, 2022

@etimberg @kurkle Updated the tests, but still getting an error, maybe you could help me with that. Chart.plugins config.options.plugins × should filter event callbacks by plugin events array Error: Timeout - Async function did not complete within 5000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL) at <Jasmine>

This error usually happens when the window running the tests is not active (Chrome does not fire events when hidden)

Looks like you still need to update this one:
/base/test/fixtures/element.point/rotation.js

@kurkle
Copy link
Member

kurkle commented Nov 12, 2022

@puneetkathar1 will you be able to update this?

@puneetkathar1
Copy link
Contributor Author

puneetkathar1 commented Nov 12, 2022 via email

@LeeLenaleee LeeLenaleee mentioned this pull request Nov 17, 2022
Merged
@etimberg etimberg closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle left review comments

@LeeLenaleee LeeLenaleee LeeLenaleee left review comments

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pointStyle: 'none'
4 participants
@puneetkathar1 @kurkle @etimberg @LeeLenaleee