Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointStyle: 'none' #10755

Closed
robertosw opened this issue Oct 6, 2022 · 4 comments
Closed

pointStyle: 'none' #10755

robertosw opened this issue Oct 6, 2022 · 4 comments

Comments

@robertosw
Copy link

robertosw commented Oct 6, 2022

Feature Proposal

"Standard" Charts with pointStyle: 'circle'

image


pointStyle: 'dash' or 'line'

image

This looks so clean, but as you can see at the end of the datasets, the little dash is always visible.
If there would be an option pointStyle: 'none' this would look even more perfect

Edit:

I have just found that you can use any pointStyle together with pointRadius: 0 to achieve this. But this is just a workaround, there probably should be a pointStyle: 'none'.


Additionally, you could make "fat" lines, which just serve as a marker. This is currently not possible if your border color is semi-transparent, because the dash will be visible:

borderColor: 'hsla(148, 100%, 30%, 0.25)',
borderWidth: 10

image

Possible Implementation

Maybe just use the code from pointStyle: 'circle' and reduce the width of the circle to 0? (If it can't be invisible).
But this is kind of hacky, there is probably a cleaner solution

No response

puneetkathar1 added a commit to puneetkathar1/Chart.js that referenced this issue Oct 6, 2022
@harshit-dugar
Copy link

@robertosw @bakert can I work on this issue

@bakert
Copy link
Contributor

bakert commented Oct 7, 2022

I think you tagged the wrong person but I say go for it :)

@etimberg
Copy link
Member

etimberg commented Oct 7, 2022

There's already a PR from @puneetkathar1 for this

@etimberg etimberg linked a pull request Oct 7, 2022 that will close this issue
puneetkathar1 added a commit to puneetkathar1/Chart.js that referenced this issue Oct 9, 2022
etimberg pushed a commit that referenced this issue Nov 18, 2022
* fix-#10755

* none to false

* str to bool

* str to bool

* 10/10

* fix test

Co-authored-by: puneetkathar1 <puneetkathar1@gmail.com>
Co-authored-by: Puneet Kathar <73285338+puneetkathar1@users.noreply.github.com>
@LeeLenaleee
Copy link
Collaborator

Added in #10886

Released in V4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants