feat: chaosctl for print debug info #1074

Yiyiyimu · 2020-10-18T13:03:01Z

Signed-off-by: yiyiyimu wosoyoung@gmail.com

What's this PR did

fix #694

Checklist

SUPPORT CHAOS

NetworkChaos
StressChaos
IoChaos

DEBUG

compare with expected (a demo for networkChaos)
move to ctrl.client from shell
chaos applied on multiple pods (larger radius): use utils.selectPods
replace extractFromJson with type assert (as how controllers do)
create daemon client locally to get pid more robustly
add test case
add backup for pod that not has ls, ps and cat
add feature to print log from all chaos-mesh components as chaosctl logs

CTL

add color to output title
use format "chaosctl debug xxxchaos"
support chaos in certain namespace
use kubectl compatible auto-completion as chaosctl debug xxxchaos CHAOSNAME -n NAMESPACE

Yiyiyimu · 2020-10-18T13:03:53Z

~~Should open in personal repo~~
Reopen for review

codecov-io · 2020-10-19T10:32:50Z

Codecov Report

Merging #1074 (befa280) into master (7e9ff3f) will decrease coverage by 2.34%.
The diff coverage is 52.68%.

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
- Coverage   55.78%   53.43%   -2.35%     
==========================================
  Files          68       83      +15     
  Lines        4383     5225     +842     
==========================================
+ Hits         2445     2792     +347     
- Misses       1768     2165     +397     
- Partials      170      268      +98

Impacted Files	Coverage Δ
api/v1alpha1/common_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/common_webhook.go	`100.00% <ø> (ø)`
api/v1alpha1/dnschaos_type.go	`0.00% <0.00%> (ø)`
api/v1alpha1/dnschaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/httpchaos_types.go	`0.00% <0.00%> (ø)`
api/v1alpha1/iochaos_types.go	`0.00% <ø> (-40.00%)`	⬇️
api/v1alpha1/jvmchaos_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/kernelchaos_types.go	`0.00% <ø> (-20.00%)`	⬇️
api/v1alpha1/kernelchaos_webhook.go	`100.00% <ø> (+14.81%)`	⬆️
api/v1alpha1/kinds.go	`27.27% <ø> (+0.60%)`	⬆️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adde61...befa280. Read the comment docs.

Yiyiyimu · 2020-10-19T10:58:52Z

~~It seems that make check on the local environment could not fix the current issue in Github Action~~
fix by upgrade cobra to v1.1.1, details in spf13/cobra#1259

Signed-off-by: yiyiyimu <wosoyoung@gmail.com> add cobra based CTL Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

…o network-debug

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

YangKeao

It seems that you have misunderstood programming on kubernetes. I will talk with you in detail 😢

pkg/debug/networkchaos/networkchaos.go

pkg/debug/common/common.go

…tput Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

pkg/chaosctl/cmd/completion.go

pkg/chaosctl/cmd/debug.go

yeya24 · 2020-10-28T16:57:21Z

pkg/chaosctl/cmd/debug.go

+}
+
+func flagCompletion(cmd *cobra.Command) error {
+	k8sConfig, err := config.GetConfig()


Would be good to switch to https://github.com/kubernetes/cli-runtime and use its factory to initialize the k8s config and client.

This supports more kubectl options like --context, --server by default.

Sure I'll try to only use one type of client

pkg/chaosctl/cmd/completion.go

pkg/debug/common/common.go

pkg/debug/networkchaos/networkchaos.go

pkg/debug/common/common.go

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

…Json Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

pkg/debug/common/common.go

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

…o network-debug

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

…o network-debug

Yiyiyimu · 2020-12-08T06:43:14Z

@YangKeao @STRRL Thanks for the review! PTAL

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

YangKeao · 2020-12-09T05:43:43Z

pkg/chaosctl/common/exec.go

+		// we need to enter mount namespace to get file related infomation
+		// but enter mnt ns would prevent us to access `cat`/`ls` in daemon
+		// so use `nsexec` to achieve using nsenter and cat together
+		newCmd := fmt.Sprintf("/usr/local/bin/nsexec %s %s", strconv.Itoa(pid), cmd)


I came up with a better idea to implement a more general nsexec 🍻 . You can find the source code and documents at https://github.com/YangKeao/nsexec, and it will be brought to chaos-daemon in #1260 .

I don't know whether it's a big project to migrate to YangKeao/nsexec.

Cool I test it and it works fine. I'll commit the change till #1260 got merged.

@YangKeao Updated to #1260, PTAL

pkg/chaosctl/common/exec.go

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu · 2020-12-16T13:24:34Z

Hi @YangKeao @STRRL PTAL

pkg/portforward/portforward.go

STRRL

LGTM

Thanks for your contribution @Yiyiyimu!

YangKeao

LGTM

It finally arrives! (Maybe we need a document later 😺 ) 🍻

YangKeao · 2020-12-17T11:50:43Z

/merge

ti-srebot · 2020-12-17T11:53:10Z

/run-all-tests

ti-srebot · 2020-12-17T12:17:30Z

cherry pick to release-1.0 failed

zhouqiang-cl · 2020-12-17T12:28:29Z

Is there have readme about this tool? @Yiyiyimu

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

* feat: chaosctl for print debug info (#1074) Signed-off-by: yiyiyimu <wosoyoung@gmail.com> * move genrateNNodes out of test file Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

ti-srebot added the contribution label Oct 18, 2020

Yiyiyimu closed this Oct 18, 2020

Yiyiyimu reopened this Oct 19, 2020

Yiyiyimu marked this pull request as draft October 19, 2020 10:00

networkchaos debug output

1baed24

Signed-off-by: yiyiyimu <wosoyoung@gmail.com> add cobra based CTL Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu force-pushed the network-debug branch from ffa4d24 to 1baed24 Compare October 20, 2020 05:37

Yiyiyimu marked this pull request as ready for review October 20, 2020 05:38

Yiyiyimu added 2 commits October 20, 2020 15:02

Merge branch 'master' into network-debug

be9ddaf

add stresschaos & refactor

c7e0ba2

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu changed the title ~~NetworkChaos Debug Info & Basic CTL~~ Debug tools & Basic CTL Oct 22, 2020

Yiyiyimu added 3 commits October 24, 2020 17:52

add completion for namespace

99cfdeb

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Merge branch 'master' of https://github.com/chaos-mesh/chaos-mesh int…

02cd30d

…o network-debug

implement iochaos debug

a68f734

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

YangKeao requested changes Oct 26, 2020

View reviewed changes

pkg/debug/networkchaos/networkchaos.go Outdated Show resolved Hide resolved

pkg/debug/common/common.go Outdated Show resolved Hide resolved

Yiyiyimu added 2 commits October 26, 2020 16:00

1. add compare-with-expect demo 2. wait till chaos start 3. format ou…

0df456b

…tput Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

move from shell-wise to client-go

e08803d

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

yeya24 reviewed Oct 28, 2020

View reviewed changes

pkg/chaosctl/cmd/completion.go Show resolved Hide resolved

yeya24 reviewed Oct 28, 2020

View reviewed changes

pkg/chaosctl/cmd/completion.go Show resolved Hide resolved

yeya24 reviewed Oct 28, 2020

View reviewed changes

pkg/debug/common/common.go Outdated Show resolved Hide resolved

YangKeao reviewed Oct 29, 2020

View reviewed changes

pkg/debug/networkchaos/networkchaos.go Outdated Show resolved Hide resolved

pkg/debug/common/common.go Outdated Show resolved Hide resolved

Yiyiyimu added 2 commits October 29, 2020 16:37

init client in one place & refactor

26eaa3a

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

1. Support larger radius 2. use type assertion to replace ExtractFrom…

e20ae0f

…Json Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu commented Nov 2, 2020

View reviewed changes

pkg/debug/common/common.go Outdated Show resolved Hide resolved

Yiyiyimu added 3 commits November 4, 2020 15:50

1. kubectl like ctl format; 2.chaos completion

3303cc4

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Merge branch 'master' into network-debug

cc2943c

create local daemon client, port forward and get pid, to replace Log()

f4bb471

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu added 6 commits December 4, 2020 11:39

Merge branch 'master' of https://github.com/chaos-mesh/chaos-mesh int…

efef2ba

…o network-debug

Use ExecBypass to exec in target pod & fix as review suggest

f3df88a

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

merge master

e65b84b

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

print info of all PID when needed

5993a7d

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

return not-support error when using stress-ng stressors

5dc5c4e

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Merge branch 'master' of https://github.com/chaos-mesh/chaos-mesh int…

44ac0b7

…o network-debug

show cgroups info for stressng stressors

9e84532

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

YangKeao reviewed Dec 9, 2020

View reviewed changes

YangKeao added the needs-cherry-pick-1.0 label Dec 9, 2020

STRRL reviewed Dec 10, 2020

View reviewed changes

pkg/chaosctl/common/exec.go Outdated Show resolved Hide resolved

Yiyiyimu added 4 commits December 13, 2020 11:34

use chaos-mesh/nsexec

7f0e334

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

merge master

bd6baa1

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

disable port forward log for ctl

43909e5

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

move portforward from e2e to pkg

befa280

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

STRRL reviewed Dec 17, 2020

View reviewed changes

pkg/portforward/portforward.go Show resolved Hide resolved

STRRL approved these changes Dec 17, 2020

View reviewed changes

YangKeao approved these changes Dec 17, 2020

View reviewed changes

ti-srebot added the status/can-merge label Dec 17, 2020

Merge branch 'master' into network-debug

2128638

ti-srebot merged commit d9c7291 into chaos-mesh:master Dec 17, 2020

Yiyiyimu added a commit to Yiyiyimu/chaos-mesh that referenced this pull request Dec 18, 2020

feat: chaosctl for print debug info (chaos-mesh#1074)

52bb3dd

Signed-off-by: yiyiyimu <wosoyoung@gmail.com>

Yiyiyimu mentioned this pull request Dec 18, 2020

feat: chaosctl for print debug info (#1074) #1302

Merged

15 tasks

dcalvin mentioned this pull request Feb 5, 2021

promote committers #1492

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: chaosctl for print debug info #1074

feat: chaosctl for print debug info #1074

Yiyiyimu commented Oct 18, 2020 •

edited

Yiyiyimu commented Oct 18, 2020 •

edited

codecov-io commented Oct 19, 2020 •

edited

Yiyiyimu commented Oct 19, 2020 •

edited

YangKeao left a comment

yeya24 Oct 28, 2020

Yiyiyimu Oct 29, 2020

Yiyiyimu commented Dec 8, 2020

YangKeao Dec 9, 2020

Yiyiyimu Dec 10, 2020

Yiyiyimu Dec 14, 2020

Yiyiyimu commented Dec 16, 2020

STRRL left a comment

YangKeao left a comment

YangKeao commented Dec 17, 2020

ti-srebot commented Dec 17, 2020

ti-srebot commented Dec 17, 2020

zhouqiang-cl commented Dec 17, 2020

feat: chaosctl for print debug info #1074

feat: chaosctl for print debug info #1074

Conversation

Yiyiyimu commented Oct 18, 2020 • edited

What's this PR did

Checklist

Yiyiyimu commented Oct 18, 2020 • edited

codecov-io commented Oct 19, 2020 • edited

Codecov Report

Yiyiyimu commented Oct 19, 2020 • edited

YangKeao left a comment

Choose a reason for hiding this comment

yeya24 Oct 28, 2020

Choose a reason for hiding this comment

Yiyiyimu Oct 29, 2020

Choose a reason for hiding this comment

Yiyiyimu commented Dec 8, 2020

YangKeao Dec 9, 2020

Choose a reason for hiding this comment

Yiyiyimu Dec 10, 2020

Choose a reason for hiding this comment

Yiyiyimu Dec 14, 2020

Choose a reason for hiding this comment

Yiyiyimu commented Dec 16, 2020

STRRL left a comment

Choose a reason for hiding this comment

YangKeao left a comment

Choose a reason for hiding this comment

YangKeao commented Dec 17, 2020

ti-srebot commented Dec 17, 2020

ti-srebot commented Dec 17, 2020

zhouqiang-cl commented Dec 17, 2020

Yiyiyimu commented Oct 18, 2020 •

edited

Yiyiyimu commented Oct 18, 2020 •

edited

codecov-io commented Oct 19, 2020 •

edited

Yiyiyimu commented Oct 19, 2020 •

edited